sandeepmistry / arduino-LoRa

An Arduino library for sending and receiving data using LoRa radios.
MIT License
1.61k stars 621 forks source link

Updated interrupt based blocking callback to loop based non-blocking one #621

Open sheikhmishar opened 1 year ago

sheikhmishar commented 1 year ago

As I noticed from the source code, the onTxDone and onReceive callback is executed in an ISR. According to Arduino and ESP documentation, ISR should run nothing more than simple variable manipulation. Also, delay will not work. I have updated the code to sort out these limitations. Please accept this pull request if you think this could be helpful in time critical application