sandeepmistry / node-chip-io

Johnny-Five IO Plugin for the Next Thing Co. C.H.I.P.
MIT License
96 stars 28 forks source link

Add Charge / Discharge amps sensor to features #45

Closed norgeous closed 3 years ago

norgeous commented 7 years ago

Adding in some more features from battery.sh Charge / Discharge amps I have tested it and it appears to work! I hope that I have integrated this properly, however, I have adjusted AXP209.prototype._readAdc, please review and let me know if this change is suitable. Also I am unsure of the pins.json file use, I have called the pins BATC and BATD, perhaps this could be named more appropriately.

norgeous commented 7 years ago

Will it ever be merged?

sandeepmistry commented 7 years ago

@norgeous eventually, I need to have the hardware on hand to test with, plus I'm away on travel for a few months.