search

sandeepmistry / node-powermate

A Node.js library for the Griffin PowerMate
41 stars 25 forks source link

Publish New Version #14

Closed foxxyz closed 6 years ago

foxxyz commented 6 years ago

Can you please publish a new version to NPM? Last release was 2 years ago, would be nice to get some of the updates since then (E.G. disconnected event on disconnect).

Thanks!

brunoimbrizi commented 6 years ago

I was just about to open an issue regarding the disconnect and I noticed it has already been addressed, but the fix hasn't been published to npm yet. Can you npm publish please?

foxxyz commented 6 years ago

In addition, looks like node-hid dependency breaks using Node v10 on OSX. 

 LIBTOOL-STATIC Release/hidapi.a
  CXX(target) Release/obj.target/HID/src/HID.o
../src/HID.cc:207:45: error: no matching member function for call to 'NewInstance'
    Local<Object> buf = nodeBufConstructor->NewInstance(1, nodeBufferArgs);
                        ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

Version in package.json is 0.5.x, current version is 0.7.2

Perhaps this can be updated also.

sandeepmistry commented 6 years ago

@foxxyz @brunoimbrizi I've published v0.1.0 to npm now.

@foxxyz for the node-hid dependency bump, please try it out and then submit a pull request if everything looks ok.

foxxyz commented 6 years ago

@sandeepmistry Thank you! Pull request ready at #15