search

sandeepmohan23 / yfai_data_migration

YFAI Data Migration
0 stars 0 forks source link

ng4LaunchSite split logic seems to be wrong #50

Open rajender2k opened 7 years ago

rajender2k commented 7 years ago

HI Prem, This logic seems to be not correct... If ng4LaunchSite doesn't contain the comma value(,) then whole value should be assigned to yf5_LeadMfgCountry NOT to yf5_MfgRegion/

    <attr-check if="@ng4LaunchSite != null">
        <attribute name="yf5_MfgRegion" value="@ng4LaunchSite"/>
    </attr-check>
    <attr-check if="@ng4LaunchSite != null and @ng4LaunchSite.Contains(',')"> 
        <attribute name="yf5_MfgRegion" value="@ng4LaunchSite.Split(',')[1]"/> 
        <attribute name="yf5_LeadMfgCountry" value="@ng4LaunchSite.Split(',')[0]"/> 
    </attr-check>

Thanks Raj

rajender2k commented 7 years ago

Inconsistent split logic for Ng4_ProgramRev and MasterPrg Rev

Ln#696
  <!--Ng4_MasterPrgRevision-->
  <map a="A9_ProgramItemRevision" b="A9_ProgramItemRevision">

        <attr-check if="@ng4LaunchSite != null">
                <attribute name="yf5_MfgRegion" value="@ng4LaunchSite"/>
        </attr-check>
        <attr-check if="@ng4LaunchSite != null and @ng4LaunchSite.Contains(',')"> 
                <attribute name="yf5_MfgRegion" value="@ng4LaunchSite.Split(',')[1]"/> 
                <attribute name="yf5_LeadMfgCountry" value="@ng4LaunchSite.Split(',')[0]"/> 
        </attr-check>

Ln#1007
  <!--Ng4_ProgramRevision-->
  <map a="A9_ProgramItemRevision" b="A9_ProgramItemRevision">

<attr-check if="@ng4LaunchSite != null">
                        <attribute name="yf5_MfgRegion" value="@ng4LaunchSite"/>
                </attr-check>
                <attr-check  if="@ng4LaunchSite != null and @ng4LaunchSite.Contains(',')">
                        <attribute name="yf5_MfgRegion" value="@ng4LaunchSite.Split(',')[0]"/>
                        <attribute name="yf5_LeadMfgCountry" value="@ng4LaunchSite.Split(',')[1]"/>
                </attr-check>
                <attr-check  if="@ng4OEMName != null">
                        <attribute name="yf5_OEMName" value="@ng4OEMName"/>
                </attr-check>
                <attr-check  if="@ng4OEMName != null and @ng4OEMName.Contains('-')">
                        <attribute name="yf5_OEMName" value="@ng4OEMName.Split('-')[0]"/>
                        <attribute name="yf5_OEMSubGroup" value="@ng4OEMName.Split('-')[1]"/>
                </attr-check>
                <attr>