search

sandeepmohan23 / yfai_data_migration

YFAI Data Migration
0 stars 0 forks source link

yf5_CADRequired takes 4 chars only,value=False can't make it #9

Closed rajender2k closed 7 years ago

rajender2k commented 7 years ago

ng4_IsDesignRequired on Ng4_PartRevision is mapped to yf5_CADRequired on A9_autoproductRevision.

But in target yf5_CADRequired max length is 4 char.. We need to truncate to 4 char for this iteration. Need decision for next iteration.

Mapping:

ng4_IsDesignRequired yf5_CADRequired E.g. ~~~~~~~~~~~~ SRC: C:\apps\Siemens\Site_Consolidation\TEST_ITERATION_2\test_export\assy_transfer\ALL_ASSY_ITEMS_PART_265.xml ~~~~~~~~~~~~ TGT: C:\apps\Siemens\Site_Consolidation\TEST_ITERATION_2\test_transform\Pass2\transformed_clean\assy_transfer\ALL_ASSY_ITEMS_PART_265.xml ~~~~~~~~~~~~
sandeepmohan23 commented 7 years ago

@rajender2k @premshankar1 the target attribute yf5_CadRequired is of size 4 because it has an LOV attached to it that has values of "yes" or "no".

@premshankar1 for iteration 3, could you please update the mappings such that if source value = true then target = yes if source value = false then target = no

premshankar1 commented 7 years ago

Will include in the xml for iteration 3

rajender2k commented 7 years ago

Hi Prem, It seems to be you are not updated mapping XML with fixes for all the mapping issues we noticed in Iteration 2. Please go thru all the open mapping issues and update mapping XML accordingly.

Thx Raj

premshankar1 commented 7 years ago

Updated Conversion.xml. Not tested yet

premshankar1 commented 7 years ago

Testing successful. However, found instances where the source value is 'false' and 'False'. Modified the code to take care of both.

premshankar1 commented 7 years ago

Tested OK

premshankar1 commented 7 years ago

In the newly exported files, I am seeing values of type ng4_IsDesignRequired="Yes". We had mapped "true"/"True" => "yes". In the target system it will go as "Yes". Will it be an issue?

Example file: C:\apps\Siemens\Site_Consolidation\TEST_ITERATION_3\test_export\assy_transfer\ALL_ASSY_ITEMS_PART_1.xml

sandeepmohan23 commented 7 years ago

@premshankar1 are you referring to the difference in lowercase vs mixed case? We would want the value to match what is in the LOV. In the target system the Lov is "Yes" and "No" (mixed case), so we would want the values from the source transformed accodingly.