sander / code-illuminated

Automatically exported from code.google.com/p/code-illuminated
0 stars 0 forks source link

With IE "{{{" and "}}}" multiline block problem #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
With IE the text between "{{{" and "}}}", when it is multiline, is not
rendered correctly. Probably "white-space: pre;" is not handled correctly
due to end line "\n" and not "\r\n".

Original issue reported on code.google.com by albertos...@gmail.com on 1 Feb 2009 at 3:15

GoogleCodeExporter commented 9 years ago
If there are any problems regarding wiki engine, please do not hesitate to 
contact
me. I keep tracking bug reports.

Original comment by ifomic...@gmail.com on 1 Feb 2009 at 8:36

GoogleCodeExporter commented 9 years ago
Ivan,
  the testcase is the following text:

{{{
<div class="documentation"> (...) </div>
<div class="code"> (...) </div>
<div class="divider"/>
}}}

Inserting the text at
http://www.ivan.fomichev.name/2008/04/javascript-creole-10-wiki-markup-parser.ht
ml,
there is a difference between IE(7) and FF(3.0.5).

Original comment by albertos...@gmail.com on 1 Feb 2009 at 9:09

GoogleCodeExporter commented 9 years ago
I've fixed this bug. The new version is also available at
https://sourceforge.net/projects/jscreole/

Original comment by ifomic...@gmail.com on 3 Feb 2009 at 4:51

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the effort, but it seems the bug is still there. The carriage return 
was
stripped just before calling creole parser, so there is no output difference 
with
your fix applied. 

Again with IE it is one line. I tried with the online page and I have the same 
result.

I think the problem it is not only, at least, in the endline type or the 
white-space
cross browser issue. Our test case contains some special characters and, I 
think, the
{{{...}}} tag should be produce a <pre> tag, containing the text "..." with "<" 
and
">" to "<" and ">" chars converted.

Generally speaking, the "{{{" tag could be contain (x)html tags.

Original comment by albertos...@gmail.com on 3 Feb 2009 at 6:38

GoogleCodeExporter commented 9 years ago
Fixed. The second problem was that IE requires CR-LF line endings to render
preformatted blocks properly. HTML special chars have been always converted into
entities, so it has no concern.

ATTENTION! I introduced a new option, "forIE", that should evaluate to truth, 
if your
browser is IE. Example:

    var creole = new Parse.Simple.Creole( {
        forIE: document.all,
        interwiki: {
            WikiCreole: 'http://www.wikicreole.org/wiki/',
            Wikipedia: 'http://en.wikipedia.org/wiki/'
        },
        linkFormat: ''
    } );

Original comment by ifomic...@gmail.com on 3 Feb 2009 at 10:42

Attachments:

GoogleCodeExporter commented 9 years ago
Awesome. Ivan, thanks for your support. Fixed in revision 18.

Original comment by albertos...@gmail.com on 4 Feb 2009 at 8:06