search

sander1988 / Indego

Home Assistant Custom Component for Bosch Indego Lawn Mower
Apache License 2.0
96 stars 29 forks source link

Alerts with mower serial #217

Closed kimzeuner closed 6 months ago

kimzeuner commented 6 months ago

Added the mower serial to the alert features to be able to select the mower when multiple mowers are configured. Mower serial is optional and must not be used when only one mower is configured. Also added de.json translation file.

Used developer branch with version 5.6.2 as base.

sander1988 commented 6 months ago

@kimzeuner - I expect to test and merge this within a couple of days. Can you update the DE translation file? It got outdated due to some new functionality I just merged (on the develop branch).

sander1988 commented 6 months ago

@kimzeuner - And please add the new service translations for EN. The EN translations should always be included as it's the default/fallback language in HA.

kimzeuner commented 6 months ago

Sure, should be fixed. Let me know if anything is missing.

sander1988 commented 6 months ago

Sure, should be fixed. Let me know if anything is missing.

The 'services' translations are missing in the EN file. Can you add these?

kimzeuner commented 6 months ago

Ah sorry, missed that. Will do it tomorrow i think.

kimzeuner commented 6 months ago

en.json update finished

kimzeuner commented 6 months ago

Because we are talking about translations, do you know how i can translate the entity names and states with the translation files ? I tried to translate the state from the Alert entities from No Problem into german but with the path from the HA developer docs it didn't work. It was something like 

"entities": {
  "sensors": {
    "entity_id": {
      "state": {
        "No Problem": "Kein Problem"
      }
    }
  }
}

Also in the developer docs i have read that the state, name or whatever must be defined with a translation_key but i don't know how to use this.

sander1988 commented 6 months ago

I tried to translate the state from the Alert entities from No Problem into german but with the path from the HA developer docs it didn't work.

See commit 75d24684be26aa31d5ee66316f18f7984f1ec1f6 ; this works. I have added 'No problem'. Please create a new PR in case you would like to add more. But for me this not really a priority.

kimzeuner commented 6 months ago

Ok, i will try that. Thanks. I understand this is not on your priority list at the moment, i'm just looking for things where i can support/make the integration a bit better without deep programmer knowledge 😉.

sander1988 commented 6 months ago

@kimzeuner - Can you check Discord when you have time? I have sent you some questions. Hope you can help.