search

sander1988 / Indego

Home Assistant Custom Component for Bosch Indego Lawn Mower
Apache License 2.0
95 stars 29 forks source link

Change service name (breaking change) #64

Closed jm-73 closed 4 years ago

jm-73 commented 4 years ago

Change name to service indego.mower_command. Remove Mower and rename it to indego.command.

Shamshala commented 4 years ago

Also, what about merging indego.smart_mow into indego.command as well?

For example:

service: indego.command
data:
  smartmowing: true/false

Do we need two services for a reason which i'm missing? Or do you plan some kind of config of SmartMowing via HA?! :smiling_imp: That would be awesome and separate service make sense then.

jm-73 commented 4 years ago

The plan is to make it possible for everyone to skip the Bosch App and the Bosch SmartMowing. And to be able to make HomeAssistant to have total control!

I have also been thinking about if I should have all commands in the indego.command service.

Shamshala commented 4 years ago

:eyes: :rocket: :tada: :tada: :tada:

jm-73 commented 4 years ago

But I need your help with what kind of logic we should implement to help users with their Hassio setu of the mower. I will implement that the indego.command will accept both mow commands (mow, pause, returnToDock) AND smartmowing (enable/disable).

Shamshala commented 4 years ago

I'm not sure about what logic do you mean. IMHO the logic behind the commands and enabling/disabling smartmowing is pretty straightforward. :+1:

If we are already talking about implementing calendar settings :eyes: , then i was wondering the same thing but then i realized we have a nice new Calendar integration for HA (never used it though :laughing: , perhaps now it'll get the right purpose), which could be pretty user friendly.

jm-73 commented 4 years ago

Implemented in 1.3