search

sanderdriesen / WhatsAPINet

A .NET WhatsApp API
32 stars 48 forks source link

Small fixes #11

Closed KapteinBabbalas closed 8 years ago

KapteinBabbalas commented 8 years ago

I fixed the onMesageReceived events and missing field in FMessageIdentifierKey

janpieterz commented 8 years ago

@KapteinBabbalas thanks for your pull request. Could you try to remove your personal phone number from the commit?

KapteinBabbalas commented 8 years ago

@janpieterz I saw that , I committed a new version to overwrite the values, but how to I remove the incorrect commit ? commit d76e68a5b29bbf3fcc74679e51c32058ea44da36

janpieterz commented 8 years ago

@KapteinBabbalas this link seems to describe the method. To be honest I've never done it myself either, but it seems like a good idea not to make something this personal available for everyone ;)

http://stackoverflow.com/questions/1338728/delete-commits-from-a-branch-in-git

KapteinBabbalas commented 8 years ago

I saw that ! :-) I did remove it , it doesn't show

KapteinBabbalas commented 8 years ago

@sanderdriesen I screwed up here, will you delete this thread please. I will send you a new pull request - without my own number in it :-)

janpieterz commented 8 years ago

@KapteinBabbalas we can't delete a pull request, only close it. We could ask the staff but I don't give that a big chance (http://stackoverflow.com/questions/18318097/delete-a-closed-pull-request-from-github).

Could you remove the commit from your local repository? And did you try a push head with force after that? The only way we can get rid of this commit is by you removing it, if that is possible. I can close it but that's it.

KapteinBabbalas commented 8 years ago

Hi

I did close the pull request, and just deleted my branch and started from scratch.

On 23 July 2015 at 09:54, Jan-Pieter Zoutewelle notifications@github.com wrote:

@KapteinBabbalas https://github.com/KapteinBabbalas we can't delete a pull request, only close it. We could ask the staff but I don't give that a big chance ( http://stackoverflow.com/questions/18318097/delete-a-closed-pull-request-from-github ).

Could you remove the commit from your local repository? And did you try a push head with force after that? The only way we can get rid of this commit is by you removing it, if that is possible. I can close it but that's it.

— Reply to this email directly or view it on GitHub https://github.com/sanderdriesen/WhatsAPINet/pull/11#issuecomment-124009800 .

janpieterz commented 8 years ago

@KapteinBabbalas I know, thanks for that, but we can't delete a pull request, that is impossible. I can only lock it. The only way to remove your phone number from this is by you executing the git commands.