Issue #153 Added attributes for sheet definitions to customise preview image more

sanderfrenken / Universal-LPC-Spritesheet-Character-Generator

Character Generator based on Universal-LPC-Spritesheet

https://sanderfrenken.github.io/Universal-LPC-Spritesheet-Character-Generator/

GNU General Public License v3.0

376 stars 142 forks source link

Issue #153 Added attributes for sheet definitions to customise preview image more #154

Closed ReneeIbeji closed 1 month ago

ReneeIbeji commented 1 month ago

Added 3 attributes that can be used in the items sheet definitions :

preview_column - Represents which sprite on a row to use as the preview image (default 0)
preview_x_offset - The amount of pixels on the x axis the preview image frame is offsetted by in reference to the preview column set. (default 0)
preview_y_offset - The amount of pixels on the y axis the preview image frame is offsetted by in reference to the preview row set. (default 0)

Please note the default value for the preview row is 10. I've used these new attributes to fix the preview images for all the spear items so far.

jrconway3 commented 1 month ago

I'll try testing this out later to see if I can get it working.

jrconway3 commented 1 month ago

Finally got a chance to look, forgot about this before. Looking pretty good! Its really great being able to see weapon previews finally. Sucks we have to manually make changes to showcase the correct preview, but at least the option is there. It also lets us pick out a better preview it a different preview might look better, too.

sanderfrenken commented 1 month ago

I see you need to rebase, there are some conflicts. Thanks for the contribution already!

ReneeIbeji commented 1 month ago

OK, I don't think their should be any issues now