sanderfrenken / Universal-LPC-Spritesheet-Character-Generator

Character Generator based on Universal-LPC-Spritesheet
https://sanderfrenken.github.io/Universal-LPC-Spritesheet-Character-Generator/
GNU General Public License v3.0
376 stars 142 forks source link

Combat Animations Need Heads and Facial Assets Cut Out #157

Closed jrconway3 closed 1 month ago

jrconway3 commented 1 month ago

The LPC Revised combat animations have some hand positions that cross over with the head and face. I failed to notice this prior but its becoming more apparent. What I may do is create a "cutout" sheet to paste black over all the areas I need to cut out.

I suspect if I actually loaded Eliza's heads these cutouts would have been present for the heads. I have noticed it is applied to the beards and the like.

These cutouts, far as I can tell, are only necessary on the "south" facing swing animations. That being said, its possible some cutouts might be necessary on the side view for assets that extend beyond the head a bit, as the hands get very close to the head for frames 2-6 of the main slash animation, but mostly in frames 3-5.

jrconway3 commented 1 month ago

On that note, it makes more sense why the hands would be standardized between certain animations. If we need to do head cutouts, the arms need to be the same sizes. So the combat animations probably do work better having similar bodies and identical arms between the "thin" and "thick" male bodies. That said, this is only necessary if head cutouts are necessary.

I think I'll drop a "cutout" sheet in the next PR that includes all the cutouts. It will also include south facing jump and south facing combat, but of course the original "shoot" animation cutouts, too. Basically without LPC tools working properly (and not including the newly added animations), this will be an alternate method to easily do cutouts; just select all black on this sheet, switch to the frame you wish to perform the cutout on and delete.