search

sanderlab / alignmentviewer

Multiple sequence alignment visualizer
http://alignmentviewer.org
MIT License
27 stars 6 forks source link

Running code through prettier #36

Closed drew-diamantoukos closed 5 years ago

drew-diamantoukos commented 5 years ago

Currently working on upgrading parts of the codebase with the end goal of adding in a tab for a U-Map visualization.

Breaking the modernization into chunks, this first PR has no functionality changes as it just introduces a simple package.json with the code run through prettier to establish a baseline format.

cc @npgauth

sacdallago commented 5 years ago

Please, don't merge this in master. Let's make a develop branch and merge in there. Master is live at https://alignmentviewer.org && used by evcouplings

Edit: develop branch: https://github.com/dfci/alignmentviewer/tree/develop

sacdallago commented 5 years ago

(not claiming this PR is bad, I think it's brilliant. It's just that it's a bit too many changes to smoothly test out, esp. since we don't have automated tests. Also currently is bad for production, even if production just relies on the built. Better just to merge in master when the changes are cosmetic, functional and complete)

npgauth commented 5 years ago

We will definitely run all changes by you before any merging! This is all in preparation to add a UMAP sequence space viewer as an extra tab :-)

Probably worth a discussion with you before we starting adding though — what is your availability looking like early next week?

On July 5, 2019 at 08:39:38, Christian Dallago (notifications@github.com) wrote:

(not claiming this PR is bad, I think it's brilliant. It's just that it's a bit too many changes to smoothly test out, esp. since we don't have automated tests. Also currently is bad for production, even if production just relies on the built. Better just to merge in master when the changes are cosmetic, functional and complete)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dfci/alignmentviewer/pull/36?email_source=notifications&email_token=AAXIXXVQWO6C2NKSXH7EVPDP546IVA5CNFSM4H5MGXKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZJNPPA#issuecomment-508745660, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXIXXQA67TNC5Y32OAWFJTP546IVANCNFSM4H5MGXKA .

drew-diamantoukos commented 5 years ago

Ah, for sure - thanks @sacdallago !

sacdallago commented 5 years ago

This isn't my work. I'm just maintaining this as part of evcouplings :) @rocreguant is probably better suited for high level decisions. I'm happy to talk though -- I was long thinking about making this a bit more... modular, reorganize. Just didn't get to it when there.

Mail me some possible meeting times your morning time? That's my afternoon ;)