search

sanderlab / tumorcomparer

A computational method for comparing cellular profiles with the flexibility to place a higher weight on functional features of interest.
Other
12 stars 3 forks source link

Package build warnings #5

Closed hakobyansiras closed 3 years ago

hakobyansiras commented 3 years ago

1st warning Warning: Maintainer: ‘Rileen Sinha rileen@gmail.com, Augustin Luna aluna@jimmy.harvard.edu’ The maintainer field is invalid or specifies more than one person

2nd warning Warning: Undocumented arguments in documentation object 'plot_balloon_plot' ‘xlab’

link: https://github.com/hakobyansiras/tumorcomparer/runs/2810749256?check_suite_focus=true

cannin commented 3 years ago

First Warning

1st warning change to:

Authors@R: c( person("Hadley", "Wickham", email = "hadley@rstudio.com", role = "cre"), person("Winston", "Chang", email = "winston@rstudio.com", role = "at"))

See: https://r-pkgs.org/description.html

Second Warning

Add

`

' @param xlab a string to be the x axis label for the plot

` After param title

hakobyansiras commented 3 years ago

Package build notes

❯ checking CRAN incoming feasibility ... NOTE Maintainer: ‘Augustin Luna aluna@jimmy.harvard.edu’

The Title field starts with the package name. The Title field should be in title case. Current version is: ‘tumorcomparer: Compare patient samples to cell line models using molecular data and weighted similarity’ In title case that is: ‘Tumorcomparer: Compare Patient Samples to Cell Line Models using Molecular Data and Weighted Similarity’

The Date field is over a month old.

Size of tarball: 24596564 bytes

Found the following URLs which should use \doi (with the DOI name only): File ‘tcga_pancan_pathway_genes.Rd’: https://doi.org/10.1016/j.cell.2018.03.035

❯ checking installed package size ... NOTE installed size is 41.1Mb sub-directories of 1Mb or more: extdata 26.5Mb shinyApp 5.4Mb test_output 8.0Mb

❯ checking DESCRIPTION meta-information ... NOTE Malformed Description field: should contain one or more complete sentences. Maintainer field differs from that derived from Authors@R Maintainer: ‘Augustin Luna aluna@jimmy.harvard.edu’ Authors@R: ‘Rileen Sinha rileen@gmail.com’

❯ checking top-level files ... NOTE Non-standard file/directory found at top level: ‘LICENSE.md’

❯ checking R code for possible problems ... NOTE plot_joyplot: no visible binding for global variable ‘Var1’ plot_joyplot: no visible binding for global variable ‘value’ Undefined global functions or variables: Var1 value

link: https://github.com/hakobyansiras/tumorcomparer/runs/2821170464?check_suite_focus=true