Update to KivyMD 2.0.0 (WIP, incomplete, do not merge)

sanderland / katrain

Improve your Baduk skills by training with KataGo!

Other

1.58k stars 223 forks source link

Update to KivyMD 2.0.0 (WIP, incomplete, do not merge) #684

Closed unelsson closed 3 months ago

unelsson commented 3 months ago

This PR is a hack that allows the basic use of KivyMD 2.0.0. The purpose is to create a working version with minimum effort possible.

What needs to be done before merging:

check that NavigationLayout -> MDNavigationLayout is the proper way
update the checkbox color properly (not just force "red")
kivyutils import BaseFabButton and BaseButton, but only BaseFabButton is used
check what SizedButton should actually do
fix whatever is causing [Clock ] Warning, too much iteration done before the next frame.
fix the issues of drawing SizedButton, including the text not drawn to correct position

Note: As of 22.5.2024 I've stopped working on this PR. There is another PR for KivyMD 1.1.1.

unelsson commented 3 months ago

This commit probably has better fixes, but the branch kivybump has several commits that seem to touch other things as well. https://github.com/sanderland/katrain/commit/3d9d59ee2f8ef2ba302eddfccfb93fc2fe7babd4

unelsson commented 3 months ago

Found this titled "Minor changes" NavigationLayout changed to MDNavigationLayout https://github.com/kivymd/KivyMD/pull/709 . So that's about right.

Refactor buttons here. MDRaisedButton looks similar to MDFlatButton. https://github.com/kivymd/KivyMD/pull/1139

unelsson commented 3 months ago

Screenshot from 2024-05-22 17-43-13 Most/many problems are solved, but it's a mystery why there's a padding area between the board and the right-side panel. That breaks also mouse clicks on widgets, e.g. the correct place for Play and Analyze buttons is the spot where the click works, but the graphics are strangely drawn too much to the right.

edit: These strange layout issues are only present with git master branch KivyMD 2.0.0. (there is no release yet). There's also no guarantee that API will stay like it is. However, when using MDFlatButton with KivyMD 1.1.1 we don't get these issues, so it's possibly a bug in the git version. It may be for the best to update just to KivyMD 1.1.1.