search

sanderland / katrain

Improve your Baduk skills by training with KataGo!
Other
1.58k stars 223 forks source link

Add poetry and bump dependencies #701

Closed lykahb closed 3 weeks ago

lykahb commented 1 month ago

The configuration with pyproject.toml is a more declarative convention.

One breaking change is that the minimal version of Python is raised 3.7 to 3.9 to upgrade the dependencies to the most recent versions.

I verified that katrain works and ran the CI scripts manually for the test and release workflows. Testing the MacOSX packaging seems to be much easier with CI.

sanderland commented 3 weeks ago

Can you also check the docs and see if they refer to requirements.txt?

lykahb commented 3 weeks ago

Rebased on the sanderland:1.15.0 branch. There should be no more references to the older build system, in particular to the requirements.txt.

sanderland commented 3 weeks ago

Thank you! poetry-dynamic-versioning is a neat plugin as well.

sanderland commented 3 weeks ago

https://github.com/sanderland/katrain/actions/runs/10434894929/job/28898286719 Aside from pypi auth having changed, this doesn't look good:

Publishing KaTrain (0.0.0) to PyPI

edit: fixed by

poetry self add "poetry-dynamic-versioning[plugin]"

lykahb commented 3 weeks ago

Sorry about that, testing on a clean virtual env could've caught it