sandermak / modulescanner

Inspect Maven Central to check what libraries are Java modules (automatic or explicit)
5 stars 3 forks source link

Modular JAR files created with recent JDK #15

Closed sormuras closed 3 years ago

sormuras commented 4 years ago
sormuras commented 3 years ago

Modules compiled for Java SE 16 are not supported!

Find some examples here: https://repo.maven.apache.org/maven2/com/github/sormuras/bach/com.github.sormuras.bach/

Those JAR files are not scanned correctly and therefore not written to the CSV files.

sormuras commented 3 years ago

I contacted Sonatype to help out by updating the underlying Java Runtime (it's 11 at the moment, iirc) that executes the modulescanner program.

sormuras commented 3 years ago

Here's another case with modules targeting Java 15.

https://github.com/sormuras/modules/discussions/18#discussioncomment-480806

scherzhaft commented 3 years ago

I contacted Sonatype to help out by updating the underlying Java Runtime (it's 11 at the moment, iirc) that executes the modulescanner program.

I have updated the Maven Central modulescanner env to jdk16. Going to do a test scan of https://repo.maven.apache.org/maven2/com/github/sormuras/bach/com.github.sormuras.bach/.

sormuras commented 3 years ago

Thanks for the update and the heads-up, Shane. As soon as your test is done, I'll trigger an update of the CSV-consuming scanner.

scherzhaft commented 3 years ago

Thanks for the update and the heads-up, Shane. As soon as your test is done, I'll trigger an update of the CSV-consuming scanner.

com.github.sormuras.bach showed up in the csv, should be all set.

sormuras commented 3 years ago

So, do I understand it correctly, that the next uploads will be parsed and included in the CSV files, which will then be pushed to the S3 bucket, as usual.

In other words, modules that target Java 12-16 that were uploaded before the update of the environment to JDK 16 are NOT included retrospectively?

scherzhaft commented 3 years ago

Correct

On Fri, Mar 26, 2021, 4:15 PM Christian Stein @.***> wrote:

So, do I understand it correctly, that the next uploads will be parsed and included in the CSV files, which will then be pushed to the S3 bucket, as usual.

In other words, modules that target Java 12-16 that were uploaded before the update of the environment to JDK 16 are NOT included retrospectively?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sandermak/modulescanner/issues/15#issuecomment-808484781, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ7Y4J3I6LT6TMLWHPJPRTTFTTO7ANCNFSM4N3PFOIA .

sormuras commented 3 years ago

image

https://github.com/sormuras/modules/commit/595594741b868cecd1f2d01326ff0fde0cc5c6fc

Module com.github.sormuras.bach was also propagated to the bucket. Due to your manual test scan, methinks.

sormuras commented 3 years ago

Closing this issue for the time being - let's open a new one for JDK 17 in September 2021.