search

sanderv32 / ngx_http_auth_yubikey_module

Yubikey basic authentication for NGINX
Other
36 stars 2 forks source link

Please merge [compile-fix] with [master]. #4

Closed teward closed 10 years ago

teward commented 10 years ago

As the compile-fix branch addresses all the breakage at compile time, as well as the 401 Unauthorized issue that had presented itself, perhaps we should consider the [compile-fix] branch as the superior, working branch. While it would not hurt to copy the current [master] branch to a [legacy] branch, or tag it as [legacy] or something prior to updating/merging, what is key is that the yubikey module works on latest stable.

NOTE: I'm still investigating whether this builds on mainline, but the same argument should still apply.

sanderv32 commented 10 years ago

Hi, I have already tagged [master] as version 1.0.0 and the [compile-fix] as version 1.1.0. My intention was to merge [compile-fix] as [master] but didn't have the time for it this morning :-)

teward commented 10 years ago

@sanderv32 cool! well, now there's a merge request to do it. XD

Hopefully you don't mind, I'm kinda impatient :)

sanderv32 commented 10 years ago

I will merge it now.. Thanks! ;-P

On Thu, Oct 2, 2014 at 7:57 PM, Thomas Ward notifications@github.com wrote:

@sanderv32 https://github.com/sanderv32 cool! well, now there's a merge request to do it. XD

Hopefully you don't mind, I'm kinda impatient :)

— Reply to this email directly or view it on GitHub https://github.com/sanderv32/ngx_http_auth_yubikey_module/pull/4#issuecomment-57672581 .

Unix is very simple, but it takes a genius to understand the simplicity. (Dennis Ritchie)