sandervanhooft / laravel-invoicable

Easy invoice creation for Laravel
https://www.sandervanhooft.com/blog/laravel/stop-creating-your-laravel-invoices-manually/
MIT License
146 stars 40 forks source link

Bump Carbon version for Laravel 5.8 #16

Closed danielfaulknor closed 5 years ago

danielfaulknor commented 5 years ago

Description

Laravel 5.8 comes with Carbon 2, so this change allows it to work with Carbon 1 or 2. According to the upgrade guide, there are no changes required for this package's current use of Carbon

Motivation and context

As above.

If it fixes an open issue, please link to the issue here (if you write fixes #num or closes #num, the issue will be automatically closed when the pull is accepted.)

How has this been tested?

I ran composer test etc as per contributing guidelines

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

sandervanhooft commented 5 years ago

Hi @danielfaulknor,

Thanks for the PR, you are right!

Can you modify it into this, so it's a bit more strict (and comparable to how the Laravel framework defines this dependency):

"nesbot/carbon": "^1.22 || ^2.0",

Cheers,

Sander

sandervanhooft commented 5 years ago

This PR will be included in the next major release.

sandervanhooft commented 5 years ago

Closing it for now.