search

sandervanvugt / cka

410 stars 520 forks source link

Update setup-kubetools.sh #15

Open dmbrownlee opened 1 year ago

dmbrownlee commented 1 year ago

Current sed line breaks /etc/fstab as it puts the '#' between '/' and "swap". Instead, match the fstype field ("swap" surrounded by spaces) and prepend a '#' to the beginning of the line if it does not already start with one (idempotent ;) ).

dmbrownlee commented 1 year ago

Not sure if you take pull requests. You'll also need to make this change in the other setup files.

Consider also removing "sudo" as you check for the root user at the start of the script.

sandervanvugt commented 1 year ago

Fixed!

Thanks for your feedback.

On 30 Mar 2023, at 22:45, D. M. Brownlee @.***> wrote:

Not sure if you take pull requests. You'll also need to make this change in the other setup files.

Consider also removing "sudo" as you check for the root user at the start of the script.

— Reply to this email directly, view it on GitHub https://github.com/sandervanvugt/cka/pull/15#issuecomment-1490928512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG3TNVULRCAHCEKC2ET5HZ3W6XWGJANCNFSM6AAAAAAWNZS6HM. You are receiving this because you are subscribed to this thread.