search

sandflow / imscJS

JavaScript library for rendering IMSC Text and Image Profile documents to HTML5
BSD 2-Clause "Simplified" License
83 stars 31 forks source link

Children text nodes of ruby container spans must be pruned after style resolution #162

Open palemieux opened 5 years ago

palemieux commented 5 years ago

https://github.com/sandflow/imscJS/blob/8d458897b38a8d6d2d5b6802637437c4ecb5f436/src/main/js/doc.js#L182

https://github.com/sandflow/imscJS/blob/8d458897b38a8d6d2d5b6802637437c4ecb5f436/src/main/js/doc.js#L633

The computed value of tts:ruby cannot be determined until after style resolution, which happens during ISD creation.

palemieux commented 5 years ago

See https://github.com/w3c/ttml2/issues/1140

cfadamp commented 4 years ago

Hi,

is this ticket about the same problem that I just discovered? See example ttml file, current IMSCJ1_1 render png, and proposed correct render png. ruby_problem.zip

Let me know if I should open a new ticket. Thanks, Adam

palemieux commented 4 years ago

@cfadamp I am not sure the rendering labeled wrong is incorrect: as far as I know, ruby text that is wider than the base does not typically overhang preceding/following Kanji -- see 3.2(4) at https://www.w3.org/TR/2020/WD-simple-ruby-20200609/

cfadamp commented 4 years ago

@palemieux thank you, I will check this out. Please ignore my comment, as it turned out it is not related to this issue.