search

sandflow / regxmllib

Convert MXF to XML: RegXML (SMPTE ST 2001-1) tools and libraries
BSD 2-Clause "Simplified" License
35 stars 14 forks source link

Added virtual destructor in Definition.h file #113

Closed ethanchan747 closed 7 years ago

palemieux commented 7 years ago

@ethanchan747 Can you rebase your branch onto the head of master?

ethanchan747 commented 7 years ago

done.

echan@Ethans-MacBook-Pro:~/lib/regxmllib$ git rebase -i a74c708ae554f6adf26f95da5831dcaab8084e36 [detached HEAD 8505f05] Changed CMakeList.txt to Author: echan echan@localhost.localdomain Date: Mon Aug 28 13:58:13 2017 -0700 2 files changed, 5 insertions(+), 2 deletions(-) Successfully rebased and updated refs/heads/master

palemieux commented 7 years ago

@ethanchan747 You have to do a git pull before the rebase. master is at adad4bc9946abacf95c76494ce63e08b181fedbc now.

ethanchan747 commented 7 years ago

Please check if rebase worked. I did a git pull.

On Mon, Oct 23, 2017 at 6:35 PM, Pierre-Anthony Lemieux < notifications@github.com> wrote:

@ethanchan747 https://github.com/ethanchan747 You have to do a git pull before the rebase. master is at adad4bc https://github.com/sandflow/regxmllib/commit/adad4bc9946abacf95c76494ce63e08b181fedbc now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sandflow/regxmllib/pull/113#issuecomment-338844924, or mute the thread https://github.com/notifications/unsubscribe-auth/AaD5EbEbjcmjQIntmwRjErFDFInUrBX_ks5svT7jgaJpZM4PVG_U .

palemieux commented 7 years ago

Moved to https://github.com/sandflow/regxmllib/pull/114