Reduce compiler warnings when built using -Wall

sandflow / regxmllib

Convert MXF to XML: RegXML (SMPTE ST 2001-1) tools and libraries

BSD 2-Clause "Simplified" License

35 stars 14 forks source link

Reduce compiler warnings when built using -Wall #132

Closed ErikCJohansson closed 6 years ago

ErikCJohansson commented 6 years ago

Building the code using the '-Wall' compiler option creates numerous warnings. The proposed fixes changes no functionality but reduces chatter when building with '-Wall' using e.g. gcc version 7.3.1.

Thanks

ErikCJohansson commented 6 years ago

It appears I've tripped over my own feet with regards to the -Woverloaded-virtual warning. It's not included in the set of warnings brought in by -Wall in most environments.

-Wsign-compare was not enabled by -Wall in my case either, which explains why I'm not seeing those.

I'll bin the changes related to the overloaded-virtual warning.

palemieux commented 6 years ago

Closing and reopening to trigger Travis