search

sandhillsdevelopment / repo-template

This is a simple template for projects containing our label definitions and issue/pr templates.
1 stars 0 forks source link

Request to change 'type-' color definitions. #1

Open cklosowski opened 5 years ago

cklosowski commented 5 years ago

Request to Change Label

Label name

type-bug type-request type-duplicate type-feature type-improvement type-regression

Requested changes

Colors to be updated: type-bug From: #76D7C4 #76D7C4 To: #d63e04 #d63e04

type-request From: #117864 #117864 To: #ffbe2e #ffbe2e

type-duplicate From: #76D7C4 #76D7C4 To: #e7f6f8 #e7f6f8

type-feature From: #76D7C4 #76D7C4 To: #00a91c #00a91c

type-improvement From: #76D7C4 #76D7C4 To: #00bde3 #00bde3

type-regression From: #76D7C4 #76D7C4 To: #f4e3db #f4e3db

Business justification for the change

After some discussion, there is some 'emotional' and 'trained' habits around the colors for types, that multiple members of the team feel help with their work flow.

DrewAPicture commented 5 years ago

Looks pretty good.

JJJ commented 5 years ago

I think Regression is more threat-level Orange than pink’ish, but changing that gets close to Request-Yellow, so here’s an alternative take:

Bug/Red: #FF2600 Regression/Orange: #FFA500 Request/Yellow: #D9FF00 Feature/Green: #00CD00 Improvement/Blue: #005AFF Duplicate/Grey: #D3D3D3

cklosowski commented 5 years ago

For reference, here are the suggested changes from @JJJ in a way that shows the color: type-bug From: #76D7C4 #76D7C4 To: #FF2600 #FF2600

type-request From: #117864 #117864 To: #D9FF00 #D9FF00

type-duplicate From: #76D7C4 #76D7C4 To: #D3D3D3 #D3D3D3

type-feature From: #76D7C4 #76D7C4 To: #00CD00 #00CD00

type-improvement From: #76D7C4 #76D7C4 To: #005AFF #005AFF

type-regression From: #76D7C4 #76D7C4 To: #FFA500 #FFA500

Edit by @JJJ: cleaned up my red/blue mess.

JJJ commented 5 years ago

Sorry @cklosowski. I edited your comment to fix my red/blue problem.

cklosowski commented 5 years ago

How does that look to everyone?

DrewAPicture commented 5 years ago

The latest iteration looks great!

cklosowski commented 5 years ago

PR is submitted: https://github.com/sandhillsdevelopment/repo-template/pull/2