sandia-minimega / minimega

minimega
GNU General Public License v3.0
148 stars 68 forks source link

ranges: split on "." #1299

Closed jcrussell closed 5 years ago

jcrussell commented 5 years ago

ranges could split on "." so that we can collapse hostnames with a common domain. Right now ["foo1.eth", "foo2.eth"] would not be collapsed into "foo[1-2].eth".

djfritz commented 5 years ago

Agreed... HOWEVER - hostnames shouldn't be named like this /rant

I wouldn't be at all surprised to hear that this naming scheme for hostnames came from the whole vlan suffix thing for interfaces - eth2.101, etc. That was so untenable that udev stepped in and started just renaming interfaces to sane things... until systemd ate udev.

At any rate, this seems fine to me - however why not ditch the notion of splitting on . and just make this generic, allowing numeric expansions anywhere:

foo[1-2]bar[6-7]

jcrussell commented 5 years ago

1327