search

sandia-minimega / minimega

minimega
GNU General Public License v3.0
148 stars 66 forks source link

minimega: shorten the sleep between container filesystem unmount retries #1350

Closed jasoncontrib closed 5 years ago

jasoncontrib commented 5 years ago

e28b548 introduced retries of filesystem unmounts for container flushes, but the sleep in between retries was 1 second. It's shortened in this PR.

djfritz commented 5 years ago

And all of this is serialized somewhere? It looks like no matter what we hit the first retry from my debug logging, so we certainly are trying to unmount too quickly after killing the container.

jasoncontrib commented 5 years ago

@djfritz Yeah, that's what I see, too. There's always the first retry.

djfritz commented 5 years ago

@jcrussell what's the reason we serialize flush again?

jcrussell commented 5 years ago

We could parallelize it, should work.

djfritz commented 5 years ago

Collapsing this into #1353 as that may be a better fix.