sandia-minimega / minimega

minimega
GNU General Public License v3.0
148 stars 68 forks source link

miniweb: Update packages to latest versions #1382

Closed mpopple closed 4 years ago

mpopple commented 5 years ago

Packages include: jQuery (3.1.1 -> 3.4.1) dataTables (1.10.12 -> 1.10.20) bootstrap (3.3.5 -> 4.3.1)

djfritz commented 4 years ago

@mwisely can you comment? There's no clean way to test this so I think we just need a sanity check re: versioning etc. Nobody knows this stuff on our team better than you.

mwisely commented 4 years ago

@mpopple @djfritz It seems to work for me, so far. The listed versions appear to be the latest stable releases, and my JS console is clear.

I'm curious if we'll see any weirdness from updating Bootstrap 3.x to 4.x, but we can handle that if/when it arises.

Looks good to me, though!

mpopple commented 4 years ago

Thanks @djfritz and @mwisely !