search

sandia-minimega / minimega

minimega
GNU General Public License v3.0
148 stars 66 forks source link

WIP: changing heiarchy to golang-standards/project-layout. compiles on go1.13+ #1427

Closed chengsteven closed 2 years ago

chengsteven commented 3 years ago

WIP: reorganize code to follow https://github.com/golang-standards/project-layout. Note, it's not an official standard defined by the Go dev team (since it looks like there is no standard) but it is an emerging layout pattern in the go ecosystem.

aherna commented 3 years ago

@chengsteven is this ready to be reviewed or do you need more time?

chengsteven commented 3 years ago

It can be reviewed. More changes can be made to truly follow that project layout but want to see if this is even desirable first

activeshadow commented 2 years ago

@aherna @chengsteven I have an updated version of the branch for this PR that I've rebased onto the current master branch and resolved conflicts for. It would be great to get this tested and merged to make development of minimega easier.

activeshadow commented 2 years ago

@aherna @chengsteven I should mention that I named my branch go-modules. I can create a new PR for it if that would make things easier. Otherwise, I can do a force push to Steven's branch if he gives me access to do so.

activeshadow commented 2 years ago

This PR can be closed. A different PR addressing this was already approved and merged.

aherna commented 2 years ago

Already Done in #1464