minimega: include image name partition not found error for disk injections

sandia-minimega / minimega

minimega

GNU General Public License v3.0

148 stars 67 forks source link

minimega: include image name partition not found error for disk injections #1443

Closed activeshadow closed 3 years ago

activeshadow commented 3 years ago

Many times, reading in a large script file will result in an error similar to the following:

desired partition 1 not found

Debugging this is difficult since no additional details are reported. This PR includes the name of the disk image being operated on.

activeshadow commented 3 years ago

@aherna just wanted to make sure you saw this PR. Very simple, but useful additional info to have.

activeshadow commented 3 years ago

@aherna FWIW I've tested it already... it came about because an experiment I was deploying with phenix kept failing due to this partition error. I ran it again with this commit in place to determine exactly which image was causing the failure. I also confirmed the logs for successfully finding the partition included the image name.

activeshadow commented 3 years ago

@aherna just curious if you were able to test this yesterday?