search

sandia-minimega / minimega

minimega
GNU General Public License v3.0
148 stars 66 forks source link

Allow user to specify which broadcast IP to use for meshage #1458

Closed activeshadow closed 2 years ago

activeshadow commented 3 years ago

In some cases, cluster compute nodes have multiple interfaces and networks they can communicate with each other over, and one may be desirable over another for meshage comms. By default, minimega uses 255.255.255.255 as the broadcast address, and when multiple interfaces are present, the one acting as the default route is the one used.

This commit adds a new command line option, -broadcast, for users to specify which broadcast IP to use for the mesh. It defaults to 255.255.255.255, so this commit should be backwards compatible.

activeshadow commented 2 years ago

@aherna anymore thoughts on this? It doesn't break normal, default behavior (i.e., it's backwards compatible) so I'm hoping you will be amenable to merging it in.

aherna commented 2 years ago

@activeshadow Havent tested the with latest changes. Is this urgent or can it wait til new year?

activeshadow commented 2 years ago

@aherna it can most definitely wait.

activeshadow commented 2 years ago

Hi @aherna just wanted to ping you on this again.