search

sandia-minimega / minimega

minimega
GNU General Public License v3.0
148 stars 67 forks source link

Refactor minimega code base to use Go Modules #1464

Closed activeshadow closed 1 year ago

activeshadow commented 2 years ago

This PR replaces #1427.

activeshadow commented 2 years ago

@aherna any movement on this? Would be great to get this merged!

aherna commented 2 years ago

@aherna any movement on this? Would be great to get this merged!

@activeshadow Were the issues resolved? Ie all.bash throwing out errors when vetting

activeshadow commented 2 years ago

@aherna any movement on this? Would be great to get this merged!

@activeshadow Were the issues resolved? Ie all.bash throwing out errors when vetting

@aherna I just ran the all.bash script and everything worked fine. I'm using Go version 1.17. What version are you testing with? It may be that I need to leave both versions of build directives in the code to support older versions of Go.

activeshadow commented 2 years ago

@aherna okay I've fixed the issue you found (was due to older versions of Go not knowing about the new go:build directive). Let's get this merged in shall we?! :+1::joy:

activeshadow commented 2 years ago

@aherna anything new with this?

activeshadow commented 2 years ago

@aherna FYSA, I've been running this branch locally and for some other customers and all is working as expected.

activeshadow commented 1 year ago

@aherna can we go ahead and get this merged by chance? I'd like to use it as the basis for the fixes and updates we're currently working on.