search

sandia-minimega / minimega

minimega
GNU General Public License v3.0
148 stars 66 forks source link

[minimega] Prevent dnsmasq from leaking DNS results #1471

Closed activeshadow closed 2 years ago

activeshadow commented 2 years ago

This commit updates the command line flags for dnsmasq to explicitly point to a non-existent resolv.conf file rather than letting it use the default /etc/resolv.conf. This prevents leakage of DNS results as described in #1421.

This commit also adds an option to the dns configure command for adding upstream DNS servers. Adding an upstream server simply adds a nameserver entry to the (initially non-existent) resolve.conf file dnsmasq is configured to use. Upstream servers added will immediately be recognized by dnsmasq since it polls the file for changes.

closes #1421

jacdavi commented 2 years ago

I think it would be beneficial to add some info about setting the upstreams in the help docs. Otherwise, everything looks good to me.

activeshadow commented 2 years ago

I think it would be beneficial to add some info about setting the upstreams in the help docs. Otherwise, everything looks good to me.

@jacdavi let me know if my latest commit is sufficient.

jacdavi commented 2 years ago

Yeah I think that's perfect. Thanks!