[minimega] Get files to be sent to miniccc via mesh before sending

sandia-minimega / minimega

minimega

GNU General Public License v3.0

148 stars 66 forks source link

[minimega] Get files to be sent to miniccc via mesh before sending #1472

Closed activeshadow closed 2 years ago

activeshadow commented 2 years ago

When a file is sent to a VM using cc, it's expected that the file is already on the node running the VM. This commit adds support for automatically getting the file to be sent to a VM from other nodes in the mesh, similar to how it's done for VM disk images when they are launched.

jacdavi commented 2 years ago

Looks good to me @aherna

jacdavi commented 2 years ago

Hey @activeshadow , I just noticed that doing a cc send seems to fail if there's a wildcard (e.g., cc send *.txt). I'm wondering if it's related to this PR since it used to work, but I'm not sure if iomHelper handles wildcards. Thoughts?

activeshadow commented 2 years ago

@jacdavi I specifically remember testing wildcard sends for this PR. However, I'm wondering if maybe #1477 broke it? At any rate, maybe open up a new issue for it and I can take a look when I have time in the next few days.