search

sandia-minimega / minimega

minimega
GNU General Public License v3.0
148 stars 66 forks source link

[minimega] Support QinQ between VMs #1487

Closed activeshadow closed 1 year ago

activeshadow commented 1 year ago

Add qinq option to VM network specification config that sets the VLAN mode to dot1q-tunnel for the network tap in Open vSwitch.

activeshadow commented 1 year ago

@aherna any thoughts on how to depict the QinQ setting for a VM in vm info? Should I modify the existing vlan column to include qinq for a particular VLAN? Or should I add a new qinq column?

aherna commented 1 year ago

@aherna any thoughts on how to depict the QinQ setting for a VM in vm info? Should I modify the existing vlan column to include qinq for a particular VLAN? Or should I add a new qinq column?

hmm since its applied at the interface level maybe it should be added as a new column with all the participating megataps in qinq for that vm?

activeshadow commented 1 year ago

@aherna okay so maybe something like this?

$> mm .column qinq vm info
host       | qinq
shadowarch | [mega_tap1 (102)]
aherna commented 1 year ago

yea perfect

activeshadow commented 1 year ago

@aherna in that case, I think this PR is ready for you to review and test as well.

activeshadow commented 1 year ago

@aherna I squashed the commits for this PR so feel free to merge at your convenience.