Update noVNC to 1.3.0; fix VNC Framebuffer Recording

sandia-minimega / minimega

minimega

GNU General Public License v3.0

148 stars 67 forks source link

Closed jacdavi closed 1 year ago

jacdavi commented 1 year ago

Update noVNC from 0.6.1 to 1.3.0
- Changelog: https://github.com/novnc/noVNC/releases
- Now stable
- New UI
- Fixed security issues
- Additional settings/controls
- Better code documentation for changes made to VNC source (should aid in future updates)
Fix recording vnc framebuffers (#1449)
- Don't print error for missing offset in rfbplay, just assume 0

jacdavi commented 1 year ago

@aherna This should be ready now. Feel free to test it out.

Was able to fix the framebuffer recording, we just weren't setting the height/width in the FramebufferUpdateRequest

aherna commented 1 year ago

@jacdavi cool ill give it a review and test. @activeshadow FYI for some of your work