Add config option for switching from xHCI to EHCI for USB controller

sandia-minimega / minimega

minimega

GNU General Public License v3.0

148 stars 67 forks source link

Add config option for switching from xHCI to EHCI for USB controller #1500

Closed jacdavi closed 1 year ago

jacdavi commented 1 year ago

This PR adds a configuration option to switch between xHCI and EHCI for the USB controller. Only one will be enabled per VM and by default xHCI is used.

To disable xHCI and use EHCI instead (as before), add vm config usb-use-xhci false to the VM's config.

This should fix two issues:

Issues observed for Windows VMs in phenix when both EHCI and xHCI are present
Backwards compatibility for certain use cases that cannot add support for xHCI (e.g., pre-2010 VMs)

jacdavi commented 1 year ago

@causand22 could you test this out? I haven't done any testing myself yet, but plan to tomorrow

causand22 commented 1 year ago

@jacdavi

Tested the following:

Launched a VM with vm config usb-use-xhci true
- hotplug USB 3.0 works: hotplug command works, drive can be mounted within vm.
Launched a VM with vm config usb-use-xhci false
- hotplug usb 3.0 throws error Error (ccc5.40g): invalid version:3.0. VM configured for EHCI instead of XHCI
- hotplug usb 2.0 works: hotplug command works
Launched VM without specifying usb-use-xhci
- Same behavior as specifying true

Looks good to me.

jacdavi commented 1 year ago

Closing in favor of #1501 since I can't approve this as the creator...