search

sandia-minimega / minimega

minimega
GNU General Public License v3.0
148 stars 66 forks source link

multiple: filepath inconsistencies #42

Closed djfritz closed 9 years ago

djfritz commented 9 years ago

Original issue 42 created by djfritz on 2014-05-07T15:57:02.000Z:

minimega, miniccc, protonuke all have bad (or at least inconsistent) use of filepath with base directories. It's mostly correct in minimega, and all other tools should use that convention.

djfritz commented 9 years ago

Comment #1 originally posted by djfritz on 2014-10-20T19:46:30.000Z:

<empty>

djfritz commented 9 years ago

Comment #2 originally posted by djfritz on 2014-10-20T23:26:48.000Z:

Changes have been pushed to the "filepath" branch, but I'd appreciate a review before I merge.

djfritz commented 9 years ago

Comment #3 originally posted by djfritz on 2014-10-21T14:57:55.000Z:

Looked it over, found one more place that needed filepath. Everything looks good to me. I'm going to run a quick few tests just to make sure.

djfritz commented 9 years ago

Comment #4 originally posted by djfritz on 2014-10-21T15:06:44.000Z:

Tested various path components in minimega, the cc interface, the file interface, miniccc, igor (on proshop), and vmbetter. Everything appears to be fine.

MERGE!

djfritz commented 9 years ago

Comment #5 originally posted by djfritz on 2014-10-21T20:07:45.000Z:

Merged, closing.