search

sandialabs / Albany

Sandia National Laboratories' Albany multiphysics code
Other
282 stars 89 forks source link

Clean up observer interfaces #1087

Closed bartgol closed 2 weeks ago

bartgol commented 3 weeks ago

Observers have lots of interfaces, depending on how they are called (e.g., with/without xdot/xdotdot, with Vector's vs a MultiVector, etc). Rather than having lots of XYZimpl functions, try to make all the interfaces call a single impl function. This makes modifications of actual implementation easier, since we only have to mod one fcn.

As a side note: I think I would remove all the MultiVector interfaces in the discretization: as I did in one of the observers, the interface that takes a MultiVector (consisting of x, possibly xdot, possibly xdotdot) can simply extract the MV columns, and call the proper interface with Vector's. This would reduce the amount of interfaces we need to implement in our classes. But that's just a wishlist thought.

bartgol commented 2 weeks ago

I merged so I can take care of any failure we may get tomorrow.