search

sandialabs / CACTUS

CACTUS (Code for Axial and Cross-flow TUrbine Simulation) is a turbine performance simulation code, based on a free wake vortex method, to study wind turbines and marine hydrokinetic (MHK) devices.
BSD 3-Clause "New" or "Revised" License
18 stars 12 forks source link

Makefile fails if GIT_VERSION cannot be identified #11

Closed whophil closed 4 years ago

whophil commented 8 years ago

Issue by whophil Thursday Jun 16, 2016 at 21:10 GMT Originally opened as https://github.com/whophil/CACTUS-SNL/issues/34

Make command fails if GIT_VERSION cannot be identified.

GIT_VERSION is used, e.g., here, and in other locations.

This may happen if:

  1. The machine doesn't have git
  2. The repository is downloaded without the .git directory
  3. git describe fails for some other reason

The fix is to add some sort of error catching to the git describe line. e.g., "if git describe fails, GIT_VERSION='unknown' "

kmruehl commented 4 years ago

@whophil I see you referenced this issue in commit https://github.com/SNL-WaterPower/CACTUS/commit/d0ce361706154044236578e57e15abee32d77892, was this issue resolved in that commit?

whophil commented 4 years ago

No, I don't think it was resolved. This issue was erroneously linked automatically by GitHub.

kmruehl commented 4 years ago

okay, good to know

whophil commented 4 years ago

Fixed with #18