Build with cmake - Githubissues

sandialabs / CACTUS

CACTUS (Code for Axial and Cross-flow TUrbine Simulation) is a turbine performance simulation code, based on a free wake vortex method, to study wind turbines and marine hydrokinetic (MHK) devices.

BSD 3-Clause "New" or "Revised" License

18 stars 12 forks source link

Build with cmake #18

Closed whophil closed 4 years ago

whophil commented 4 years ago

The previous build system of platform-specific Makefiles requiring manual modification was pretty hairy. Here is a new build setup which uses CMake, with the following advantages:

A single configuration file (CMakeLists.txt) for all platforms and options
Automatic detection of paths for OpenMP, LAPACK/BLAS
Automated dependency resolution within Fortran sources/modules - no more need to specify the compile order by hand

This will require some updates to the compile instructions, but those will conflict with #17. So let's merge that one first, and then I'll fix this PR up.

whophil commented 4 years ago

Added some changes to address #6 (PGI compiler problems) and #11 (Don't fail on missing git).

Building with the PGI compiler is not tested in Travis. It's certainly possible but I'm not sure it's worth doing.

kmruehl commented 4 years ago

@jcokemurray can you review and approve this PR?

whophil commented 4 years ago

Rebased onto the tip of dev to resolve conflicts. I removed the outdated Windows install instructions. If somebody wishes they can update doc/compile.md with Windows-specific instructions.

jcokemurray commented 4 years ago

Works for me. Cmake would definitely be an improvement over the manual Makefile approach...

kmruehl commented 4 years ago

@jcokemurray thanks for reviewing. @whophil merging this PR now.