search

sandialabs / CACTUS

CACTUS (Code for Axial and Cross-flow TUrbine Simulation) is a turbine performance simulation code, based on a free wake vortex method, to study wind turbines and marine hydrokinetic (MHK) devices.
BSD 3-Clause "New" or "Revised" License
18 stars 12 forks source link

Support longer filenames #39

Closed whophil closed 3 years ago

whophil commented 3 years ago

Does this fix #32 @danrhouck ?

danrhouck commented 3 years ago

Is this a rebuild you’d like me to try? Based on what you found on #32, I’m not sure if this is even necessary. Seems like the issue is really something to do with viewing files on a remote machine over a network vs viewing them on the networked machine. It may not have been a file name length issue to begin with, right?

From: Phil Chiu notifications@github.com Sent: Saturday, October 17, 2020 10:21 PM To: SNL-WaterPower/CACTUS CACTUS@noreply.github.com Cc: Houck, Daniel Russell drhouck@sandia.gov; Mention mention@noreply.github.com Subject: [EXTERNAL] [SNL-WaterPower/CACTUS] Support longer filenames (#39)

Does this fix #32https://github.com/SNL-WaterPower/CACTUS/issues/32 @danrhouckhttps://github.com/danrhouck ?

You can view, comment on, or merge this pull request online at:

https://github.com/SNL-WaterPower/CACTUS/pull/39

Commit Summary

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/SNL-WaterPower/CACTUS/pull/39, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP7KH35UZYMRPMA3UT4KF7TSLJUKNANCNFSM4SU2BAAA.

whophil commented 3 years ago

@danrhouck this is a fix to support file names (not absolute paths) which are up to 255 characters in length. However based on the discussion in #32 it seems this isn't really the problem. Closing this.

kmruehl commented 3 years ago

@whophil do you want to keep this branch?