search

sandialabs / Gulliver

Gulliver is a C# utility package and library engineered for the manipulation of arbitrary sized byte arrays accounting for appropriate endianness and jagged byte length.
Apache License 2.0
15 stars 3 forks source link

[BUG] NuGet releases from Azure DevOps server are labeled as being done by nbachicha #39

Open ahsteele opened 4 years ago

ahsteele commented 4 years ago

Describe the bug

Releases from Azure DevOps server are shown as being done by nbachicha even when he didn't do anything.

Expected behavior

This should be labeled w/ either my username or a general one, but definitely not Nick's: image

Example of how to Reproduce

Do a release for context see my most recent release from Azure DevOps: https://dev.azure.com/sandianationallabs/Gulliver/_releaseProgress?_a=release-pipeline-progress&releaseId=1

rheone commented 4 years ago

This is odd.

It works appropriately for me. I uploaded the first Gulliver and sure enough it shows me image

Likewise on Arcus, I think you, @ahsteele , released 2.1.0 and it has you marked as @nicksterx

image

@ahsteele , did you get the nuget artifacts from the server, or did @nicksterx send them to you? Might there be some sort of signing going on with the download from ados that is tacking on the current user's name?

nicksterx commented 4 years ago

Did it deploy it automatically from azure? If it did then it could be because I generated the API Key. We should have you or @rheone Generate the key so your names can be attached.

This detail is only visible if you are logged into the project, if you are not logged in this is what you see: image

Which is what I see for projects I am not apart of but logged in for: image

nicksterx commented 4 years ago

@rheone or @ahsteele go to https://www.nuget.org/account/apikeys and generate a new key to send to me and I will update the release pipeline.

image

ahsteele commented 4 years ago

I did the deploy from Azure.

nicksterx commented 4 years ago

Modified the release to use the org token. This should be resolved now.

nicksterx commented 4 years ago

@ahsteele So it is attached to whoever generated the API Key. Right now @rheone is listed as the package submitter on nuget. The alternative, which I don't think would be good, would be to create a SandiaLabs puppet account.

ahsteele commented 4 years ago

Anyway to have it be user specific based on who is actually pressing the deploy button?