search

sandialabs / InterSpec

spectral radiation analysis software
https://sandialabs.github.io/InterSpec
GNU Lesser General Public License v2.1
129 stars 21 forks source link

CMakeLists: create data, or symlink data? #2

Closed jpbrodsky closed 5 years ago

jpbrodsky commented 5 years ago

https://github.com/sandialabs/InterSpec/blame/master/CMakeLists.txt#L1184

This line creates the "data" folder in the build directory.

At: https://github.com/sandialabs/InterSpec/blame/master/CMakeLists.txt#L1217

The CMakeLists attempt to create a symlink to the data directory in the source code.

This creates a conflict, since the data directory already exists at the time when a data symlink is supposed to be created.

One resolution would be to move line 1184 down after the symlink is created.

wcjohns commented 5 years ago

This hadn't triggered for me, but is clearly and issue - thanks for the for the suggested fix!