search

sandialabs / LCM

Laboratory for Computational Mechanics
Other
12 stars 7 forks source link

Remove deprecated STK constructor calls from LCM #59

Closed ikalash closed 2 years ago

ikalash commented 2 years ago

The following is an email from @alanw0 đź‘Ť 

For codes that directly construct instances of the stk::mesh::BulkData class, we are introducing a MeshBuilder class which will be used as a factory to obtain instances of BulkData.

MeshBuilder is already in the Trilinos version of stk. See packages/stk/stk_mesh/stk_mesh/base/MeshBuilder.hpp.

The public BulkData constructor will be deprecated in coming weeks (exact date not specified, but “soon”).
Once we add the deprecation macro, we will wait approximately 6 weeks before removing the public constructor.

Please see the attached slides for details, and don’t hesitate to send questions and concerns to the stk team at [stk-ngpteam@sandia.gov](mailto:stk-ngpteam@sandia.gov).
Also, unit-tests may be informative, which are located at stk/stk_unit_tests/stk_mesh/UnitTestMeshBuilder.cpp

The following PR for Panzer may be relevant: https://github.com/trilinos/Trilinos/pull/10573 .

ikalash commented 2 years ago

MeshBuilder_BulkData.pptx

ikalash commented 2 years ago

This is causing build failures now: https://sems-cdash-son.sandia.gov/cdash/viewBuildError.php?buildid=35517 . I will fix it as soon as it gets fixed in Albany master.

alanw0 commented 2 years ago

Unfortunately there seems to be a significant delay in promoting develop to master these days. This complicates our deprecation strategy...

ikalash commented 2 years ago

I've fixed this.