search

sandialabs / NuMAD

Numerical Manufacturing And Design Tool (NuMAD) -- A design tool for wind and water turbine composite blades
http://numad.readthedocs.io/
Other
30 stars 19 forks source link

IEC design load case class #4

Closed kmruehl closed 2 years ago

kmruehl commented 2 years ago

This PR removed runIEC_ipt and creates a IEC design load case class, called IECDef, that is initialized by iecInputFile and executed by runIEC.

kmruehl commented 2 years ago

Sounds good. I agree that turning the IEC input file into a plain text file makes the most sense. It also reinforces that it’s truly just an input file, and will look/feel like the other NuMAD input files. I’ll go ahead and merge it now.

Kelley Ruehl (she/her) Sandia National Laboratories Phone: (505) 284-8724

From: andersone35 @.> Sent: Monday, November 8, 2021 3:48 PM To: sandialabs/NuMAD @.> Cc: Ruehl, Kelley M @.>; Author @.> Subject: [EXTERNAL] Re: [sandialabs/NuMAD] IEC design load case class (PR #4)

@andersone35 approved this pull request.

Overall this looks like it's headed in a good direction. Just FYI, Ernesto and I were talking and we think we want to turn the IEC input file itself into a plain text file, which can be named and located as the user pleases. So we'll probably do away with the '.m' style input as it stands. Also I want to make a few changes to the methods/property definitions. But I think the merge can go ahead and I will make those edits later. Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/sandialabs/NuMAD/pull/4#pullrequestreview-800682075, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABDD346IKNWOH3OFB6UYZP3ULBHQTANCNFSM5HTGU3MA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kmruehl commented 2 years ago

@ecamare is going to merge this PR