search

sandialabs / NuMAD

Numerical Manufacturing And Design Tool (NuMAD) -- A design tool for wind and water turbine composite blades
http://numad.readthedocs.io/
Other
30 stars 19 forks source link

Modularized layupDesign_ANSYSanalysis.m #8

Closed rclarke17 closed 2 years ago

rclarke17 commented 2 years ago

Made multiple functions out of layupDesign_ANSYSanalysis.m, added my modified AD2ANSYSfollower.m script that works correctly with NuMAD 3.0

ecamare commented 2 years ago

Hi Ryan, thanks for the pull request. I'd like to keep the function names beginning with a lower case. Is there a reason you preferred uppercase? Have you checked the documentation to make sure the new updates are consistent with what is in the documentation?

rclarke17 commented 2 years ago

I think when I typed it, it was out of habit. We can change it to lower case, that's no issue. Everything else should follow the documentation, I didn't actually change any of the inner workings of the code, just split it into manageable functions. Best, Ryan From: Ernesto Camarena @.> Sent: Monday, March 28, 2022 9:00 AM To: sandialabs/NuMAD @.> Cc: Clarke, Ryan @.>; Author @.> Subject: [EXTERNAL] Re: [sandialabs/NuMAD] Modularized layupDesign_ANSYSanalysis.m (PR #8)

Hi Ryan, thanks for the pull request. I'd like to keep the function names beginning with a lower case. Is there a reason you preferred uppercase? Have you checked the documentation to make sure the new updates are consistent with what is in the documentation?

- Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsandialabs%2FNuMAD%2Fpull%2F8%23issuecomment-1080763561&data=04%7C01%7Crclarke%40sandia.gov%7Cd98988ec7c2449b4e6ed08da10cba26d%7C7ccb5a20a303498cb0c129007381b574%7C1%7C0%7C637840764037897716%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Yr2b%2B1WAcAn1fRNlxUXMk%2BC66fw0S7la5mj6vzuHkpA%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVW3JD4O327AIJZLNEJLTF3VCHCO5ANCNFSM5RROPO7Q&data=04%7C01%7Crclarke%40sandia.gov%7Cd98988ec7c2449b4e6ed08da10cba26d%7C7ccb5a20a303498cb0c129007381b574%7C1%7C0%7C637840764037897716%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=U2dsD5x9JNf0wmnVAS5Jw0nm4ugSfEZPyxNquvV6xis%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>