search

sandialabs / SpecUtils

A library for opening, manipulating, and exporting gamma spectral files
GNU Lesser General Public License v2.1
26 stars 9 forks source link

Mods to support spectra file IO out of fortran #34

Open hbivens opened 1 month ago

wcjohns commented 1 month ago

This looks like a nice addition - thanks!

hbivens commented 1 week ago

@wcjohns I merged in master this am and did this cmake configuration:

$ cmake -G "Ninja" -DCMAKE_BUILD_TYPE=Debug -DSpecUtils_ENABLE_D3_CHART=OFF -DSpecUtils_BUILD_UNIT_TESTS=ON -DSpecUtils_USING_NO_THREADING=ON -DSpecUtils_FLT_PARSE_METHOD="FastFloat" -DSpecUtils_FETCH_FAST_FLOAT=ON ../../../

I'm getting this error on WSL/Ubuntu:


Args: --log_level=test_suite;--report_level=detailed;--catch_system_errors=yes
-- Configuring done (5.7s)
CMake Error in CMakeLists.txt:
  Target "SpecUtils" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/mnt/c/Projects/code/SpecUtils/out/build/WSL-GCC-Debug/_deps/fast_float-src"

  which is prefixed in the build directory.

CMake Error in CMakeLists.txt:
  Target "SpecUtils" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/mnt/c/Projects/code/SpecUtils/out/build/WSL-GCC-Debug/_deps/fast_float-src"

  which is prefixed in the build directory.Target "SpecUtils"
  INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/mnt/c/Projects/code/SpecUtils/out/build/WSL-GCC-Debug/_deps/fast_float-src"

  which is prefixed in the source directory.

-- Generating done (0.1s)
CMake Generate step failed.  Build files cannot be regenerated correctly.
wcjohns commented 1 week ago

Commit 6d8371f39d2eef24edb123a25abc738de43b13a3 should fix this - let me know if not.

hbivens commented 2 days ago

The default_value wasn't working for me, and I think that was before you fixed the FastFloat retrieval. I can revert it back to default_value.

-Hugh

Hugh P. Bivens Sandia National Laboratories Albuquerque, NM USA +1 (505) 284-6822 https://snl-wiki.sandia.gov/x/6ID2BQ

From: William Johnson @.> Sent: Monday, September 16, 2024 5:43 PM To: sandialabs/SpecUtils @.> Cc: Bivens, Hugh P. @.>; Author @.> Subject: [EXTERNAL] Re: [sandialabs/SpecUtils] Mods to support spectra file IO out of fortran (PR #34)

@wcjohns commented on this pull request.

On CMakeLists.txthttps://github.com/sandialabs/SpecUtils/pull/34#discussion_r1762087752:

If SpecUtils_FLT_PARSE_METHOD is left as 'default_value' here, there is some logic below to hopefully pick the most reasonable float parsing method. Like for MSVC ≥2019, it should pick 'FromChars'. Is there is reason to default to the slowest common denominator, or was it giving you an issue?

- Reply to this email directly, view it on GitHubhttps://github.com/sandialabs/SpecUtils/pull/34#pullrequestreview-2308000642, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADAP4BE7WQ6LSBY52EADLQLZW5UJTAVCNFSM6AAAAABLPPWDBOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBYGAYDANRUGI. You are receiving this because you authored the thread.Message ID: @.**@.>>