Closed jtgrasb closed 2 months ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 8540364958: | 0.0% |
Covered Lines: | 2505 |
Relevant Lines: | 2664 |
I made the following updates to this PR:
f1
and nfreq
- resolves #252.
f1
equal to the wave frequency and reduced nfreq
but still made sure its enough to capture nonlinear responses at the odd harmonics.
Description
This PR adds a demonstration of the selection of the frequency range, number of frequencies, and the number of irregular wave phase realizations to the end of the Pioneer tutorial. Related to #262 and #297. The three recommended processes can be summarized as follows:
One thing I have not addressed is using a structured controller (such as PI). When optimizing a PI controller across many phase realizations for a constrained system, the resulting gains are different across the different realizations. If the average PI gains were to be used, it would violate constraints for many of the realizations. This can be slightly improved by increasing the number of frequencies used (decreasing
f1
), but this does not resolve the issue. For now, I think it may be best to add a note in the docs to say something like PI gains should be tested in the time-domain to ensure constraints are met.Type of PR
Checklist for PR
Additional details