sandialabs / WecOptTool

WEC Design Optimization Toolbox
https://sandialabs.github.io/WecOptTool/
GNU General Public License v3.0
13 stars 22 forks source link

issue 321 fd_to_td() bug #329

Closed dtgaebe closed 5 months ago

dtgaebe commented 6 months ago

Description

This PR fixes a bug in in fd_to_td() when using the function without optional arguments. Now, we don't divide the DC and Nyquist component of the real valued frequency vector by 2. This solves #321

Additionally, td_to_fd() was slightly restructured, to make the scaling for single vs two-side spectrum more intuitive.

Type of PR

Checklist for PR

Additional details

Include any relevant context and describe any validation and verification efforts.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8545211409

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
wecopttool/core.py 5 6 83.33%
<!-- Total: 5 6 83.33% -->
Totals Coverage Status
Change from base Build 8545123630: 0.002%
Covered Lines: 2506
Relevant Lines: 2665

💛 - Coveralls