Closed sserita closed 8 months ago
Question for you before I approve this. If I understand everything here correctly the new workflow structure is such that:
Is splitting off main and main-mac necessary? In principle beta should track develop in which case there is little difference and these workflows could be merged. In practice this is only true when test_extras
passes, though, so I wasn't sure if this was the reason behind that difference.
Thanks for taking a look Corey - you understand the proposed workflow correctly.
The reason I split main and main-mac was to avoid the Mac runners stuffing up tests on develop, which I thought was the original intent of #387. Although rereading now, I think you may have just wanted main-minimal
and main
. The Mac tests rarely catch bugs that the linux tests do not, but we do have cases where develop fails and does not push to beta - in these cases, I thought having the more streamlined no Mac tests would be worthwhile. We do want to test the Mac environment eventually, thus we have main-mac
which runs on beta and master just so we have the full complement of tests on those branches.
I don't feel too strongly about this. If you think it is cleaner to merge the workflows and don't mind waiting for the Mac tests when we push to develop, I will change that and remerge those.
This includes several quality-of-life and deprecation runner updates and addresses #387.
beta
andmaster
.-latest
, bumping our testing environment to Ubuntu 22.04 from 20.04, Windows 2022 from 2019, and MacOS 12 from 11, and will now track updated environments.v2
tov4
(orv3
in the case ofcache
) for node16 updates, which should remove the node12 deprecation warning we've been getting.As an example, this cuts the current runtime from nearly 2 hours (with the MacOS oversubscription problem) to 13 minutes on this feature branch.