search

sandialabs / pyGSTi

A python implementation of Gate Set Tomography
http://www.pygsti.info
Apache License 2.0
134 stars 56 forks source link

Bugfix germsel correctness tests #393

Closed coreyostrove closed 8 months ago

coreyostrove commented 8 months ago

This PR updates the germ selection correctness/integration checks added to the unit tests in test_packages in a recent update to develop. These tests can be sensitive to various difference among OS and python version and so were failing on some runners. Additional solutions have been added to the tests to account for these local variations, and we now have all of the tests in the test_packages workflow passing. With the exception of python 3.11 on macOS which is failing because of an unrelated build error with CVXOPT.

~Note: New commits are 52a793ddf1ccab2f71fd0df365caa4fde828b2aa and onward. The other commits are from the bugfix-stricter-line... branch which has already been merged in, but they still seem to show in the history as new in this branch.~ It is because I had accidentally selected to merge into master, fixed now.

sserita commented 8 months ago

I merged this in now because these tests were now the failing ones on beta. I'd like to get a clean set of tests before merging in other branches in for the release.